Add quality code tests: Aqua.jl + method ambiguities test #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
requested changes
Nov 13, 2023
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 33 33
Lines 2274 2275 +1
=======================================
+ Hits 2098 2099 +1
Misses 176 176
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I will also add Aqua.jl to the quality tests so expanding a bit the breadth of this PR :-) |
Tortar
changed the title
|
Tortar
commented
Nov 13, 2023
Datseris
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolved the 22 method ambiguities in Agents.jl. Notice that this resolved a bug with nearby_ids in a no space model which was ambiguous before, all other ambiguities are less important